Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Desk link addition to Navigation #5024

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

ramyaragupathy
Copy link
Member

From #5017 - made frontend changes to let access Jira Service desk through Tasking Manager. This link can be used to report any issues that the users encounter with the application.

@d-rita - here is a snapshot from my local testing

image

The external link always is appended to the base link. Can you please help figure out what more changes are needed to make this work?

@ramyaragupathy ramyaragupathy marked this pull request as draft March 2, 2022 15:46
@d-rita
Copy link
Contributor

d-rita commented Mar 2, 2022

The Link component is mostly used to route within the application. So, for external links, we go with the anchor tag, <a />. That way, the service desk link will not be appended to the site URL before redirecting.

Additionally, the changes added so far only affect the popup menu.
popup

To affect the navbar displayed on larger screens, we'd have to apply the same changes to this part.

@zlavergne
Copy link

Just a nitpick, since this is an external link in a navbar, could we add an icon to denote it's external. Like this: https://fontawesome.com/v5/icons/external-link-alt?s=solid

@HelNershingThapa
Copy link
Contributor

An anchor tag has been added for the support link. Like @zlavergne suggested, an external link icon has also been added.
support-big

Popup:
support-small

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dakotabenjamin
Copy link
Member

Is this still WIP?

@HelNershingThapa
Copy link
Contributor

@dakotabenjamin it's done

@HelNershingThapa HelNershingThapa marked this pull request as ready for review March 25, 2022 05:01
@Aadesh-Baral Aadesh-Baral merged commit ba95a47 into develop Mar 29, 2022
@dakotabenjamin dakotabenjamin mentioned this pull request Apr 5, 2022
@Aadesh-Baral Aadesh-Baral deleted the update/support-link branch April 12, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants